Regarding diamond pattern or straight, I agree completely that straight is for knobs that need turning since they won't be that good for pulling On a serious note I would consider the pattern for a rotating knob to be cosmetical as you can choose either one or the other. However maybe you have some knob that you don't taunt to get pulled then straight would be a better choice. I chose diamond knurling for two reasons, one is that I don't have any straight wheels here as I have left them at my fathers place, second I don't want to drop this tool with oily hands.
Anywho I always refer to this document when designing a part to check how much torque I can apply,
**LINK**
Here is some more great information about knurling and computing diameters and such.
**LINK**
Ian, I would have loved to do this project long ago, but I have gotten by on newly manufactured cheap tap wrenches and at some point I got fed up with the quality and decided to look for vintage tooling, when that failed I decided to make my own. I have also designed a bigger version with movable jaws that I will start making fairly soon.